Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ParseInternalKey() to return Status instead of bool #7457

Closed
wants to merge 22 commits into from

Commits on Sep 29, 2020

  1. WIP - change ParseInternalKey() to return Status instead of bool

    Ramkumar Vadivelu committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    d9aab86 View commit details
    Browse the repository at this point in the history
  2. workaround in db/dbformat.h to avoid uninitialized field error with g…

    …++ (clang works)
    Ramkumar Vadivelu committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    d4bb356 View commit details
    Browse the repository at this point in the history
  3. fix format issue

    Ramkumar Vadivelu committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    4f13354 View commit details
    Browse the repository at this point in the history
  4. fix compiling issue with g++

    Ramkumar Vadivelu committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    b389861 View commit details
    Browse the repository at this point in the history
  5. cleanup and use ASSERT_OK instead of ASSERT_EQ

    Ramkumar Vadivelu committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    3054388 View commit details
    Browse the repository at this point in the history
  6. Merge github.com:ramvadiv/rocksdb into PR_7430

    Ramkumar Vadivelu committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    8b26683 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. removed an extra assert and comments cleanup

    Ramkumar Vadivelu committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    723cd3c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5755133 View commit details
    Browse the repository at this point in the history
  3. fix an unchecked Status in MergeUntil()

    Ramkumar Vadivelu committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    089c8f2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    003532d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dae0bd9 View commit details
    Browse the repository at this point in the history
  6. minor cleanups

    Ramkumar Vadivelu committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    d6f5900 View commit details
    Browse the repository at this point in the history
  7. made changes to address Andrew's review comments

    Ramkumar Vadivelu committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    1c249f7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8a2b35a View commit details
    Browse the repository at this point in the history
  9. fixed a compilation issue!

    Ramkumar Vadivelu committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    262164b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b8ba51c View commit details
    Browse the repository at this point in the history
  11. return false when ParseInternalKey() returns Status not OK

    Ramkumar Vadivelu committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    fd975be View commit details
    Browse the repository at this point in the history
  12. handle mark's review comment in write_batch_test.cc

    Ramkumar Vadivelu committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    8be9d4f View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    bdafbfb View commit details
    Browse the repository at this point in the history
  14. reverting an extra check in db_iter_test.cc to see whether it contrib…

    …uted to circleci: build-linux-shared_lib-alt_namespace-status_checked test failure
    Ramkumar Vadivelu committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    9f1ab41 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    a523a8a View commit details
    Browse the repository at this point in the history
  16. fix an status not checked scenario introduced in TruncatedRangeDelIte…

    …rator's constructor
    Ramkumar Vadivelu committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    9e8368b View commit details
    Browse the repository at this point in the history