LockTree library, originally from PerconaFT #7753

spetrunia · 2020-12-07T19:44:46Z

To be used for implementing Range Locking.

adamretter · 2020-12-07T20:30:06Z

What are the implications of introducing GPL2 and AGPL3 code into the RocksDB codebase?

spetrunia · 2020-12-07T20:40:16Z

@adamretter It is also licenced under Apache Licence, see utilities/transactions/lock/range/range_tree/lib/COPYING.APACHEv2

facebook-github-bot

@Cheng-Chang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ghost · 2020-12-07T21:29:42Z

@spetrunia Can we also include updates to Makefile, cmake, and TARGET?

facebook-github-bot · 2020-12-07T21:58:01Z

@spetrunia has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot

@Cheng-Chang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ghost · 2020-12-08T01:06:21Z

@spetrunia compilation in internal repo fails with errors like

stderr: In file included from internal_repo_rocksdb/repo/utilities/transactions/lock/range/range_tree/lib/locktree/manager.cc:60:
In file included from internal_repo_rocksdb/repo/utilities/transactions/lock/range/range_tree/lib/locktree/lock_request.h:58:
In file included from internal_repo_rocksdb/repo/utilities/transactions/lock/range/range_tree/lib/locktree/locktree.h:70:
internal_repo_rocksdb/repo/utilities/transactions/lock/range/range_tree/lib/util/omt.h:793:10: fatal error: 'omt.cc' file not found
#include "omt.cc"
         ^~~~~~~~
1 error generated.
Cannot execute a rule out of process. On RE worker. Thread: Thread[main,5,main]
Command failed with exit code 1.

ghost · 2020-12-08T18:47:27Z

@spetrunia compilation in internal repo fails with errors like

stderr: In file included from internal_repo_rocksdb/repo/utilities/transactions/lock/range/range_tree/lib/locktree/manager.cc:60:
In file included from internal_repo_rocksdb/repo/utilities/transactions/lock/range/range_tree/lib/locktree/lock_request.h:58:
In file included from internal_repo_rocksdb/repo/utilities/transactions/lock/range/range_tree/lib/locktree/locktree.h:70:
internal_repo_rocksdb/repo/utilities/transactions/lock/range/range_tree/lib/util/omt.h:793:10: fatal error: 'omt.cc' file not found
#include "omt.cc"
         ^~~~~~~~
1 error generated.
Cannot execute a rule out of process. On RE worker. Thread: Thread[main,5,main]
Command failed with exit code 1.

we need to include path like utilities/transactions/....../omt.cc

utilities/transactions/lock/range/range_tree/lib/locktree/treenode.h

utilities/transactions/lock/range/range_tree/lib/locktree/concurrent_tree.h

spetrunia · 2020-12-08T22:18:10Z

#include "omt.cc"

we need to include path like utilities/transactions/....../omt.cc

This is a bit odd - the library code has plenty of #include "file_in_this_directory.h" . But I've made the change. (This is the only remaining .cc file that is not a compilation unit.. should I rename it to omt_impl.h for the sake of uniformity?)

facebook-github-bot · 2020-12-08T22:26:14Z

@spetrunia has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2020-12-08T22:32:38Z

@spetrunia has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2020-12-08T22:38:19Z

@spetrunia has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2020-12-08T23:00:09Z

@spetrunia has updated the pull request. You must reimport the pull request before landing.

ghost · 2020-12-08T23:05:30Z

#include "omt.cc"
we need to include path like utilities/transactions/....../omt.cc

This is a bit odd - the library code has plenty of #include "file_in_this_directory.h" . But I've made the change. (This is the only remaining .cc file that is not a compilation unit.. should I rename it to omt_impl.h for the sake of uniformity?)

omt.h, concurrent_tree.h, and treenode.h all include their corresponding .cc, all for the template definitions.

facebook-github-bot

@Cheng-Chang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ghost · 2020-12-08T23:22:40Z

#include "omt.cc"
we need to include path like utilities/transactions/....../omt.cc

This is a bit odd - the library code has plenty of #include "file_in_this_directory.h" . But I've made the change. (This is the only remaining .cc file that is not a compilation unit.. should I rename it to omt_impl.h for the sake of uniformity?)

renaming to omt_impl.h sounds good to me.

ghost · 2020-12-09T00:58:15Z

internal build is still failing with

stderr: In file included from internal_repo_rocksdb/repo/utilities/transactions/lock/range/range_tree/lib/locktree/wfg.cc:61:
In file included from internal_repo_rocksdb/repo/utilities/transactions/lock/range/range_tree/lib/locktree/txnid_set.h:55:
In file included from internal_repo_rocksdb/repo/utilities/transactions/lock/range/range_tree/lib/portability/txn_subst.h:8:
internal_repo_rocksdb/repo/utilities/transactions/lock/range/range_tree/lib/util/omt.h:793:10: fatal error: 'utilities/transactions/lock/range/range_tree/lib/util/omt.cc' file not found
#include "utilities/transactions/lock/range/range_tree/lib/util/omt.cc"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Cannot execute a rule out of process. On RE worker. Thread: Thread[main,5,main]
Command failed with exit code 1.

facebook-github-bot · 2020-12-09T10:02:51Z

@spetrunia has updated the pull request. You must reimport the pull request before landing.

spetrunia · 2020-12-09T10:04:19Z

renaming to omt_impl.h sounds good to me.

Ok, moved.

spetrunia · 2020-12-09T10:05:16Z

Hmm, also, CMakeLists.txt adds some of library's .h files into SOURCES. Let me fix that as well

To be used for implementing Range Locking. src.mk, CMakeLists.txt and TARGETS are updated to compile the files from the library.

facebook-github-bot · 2020-12-09T10:41:42Z

@spetrunia has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot

@Cheng-Chang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2020-12-09T21:43:38Z

@Cheng-Chang merged this pull request in 98236fb.

siying · 2020-12-15T23:40:12Z

utilities/transactions/lock/range/range_tree/lib/portability/toku_pthread.h

+    GNU Affero General Public License for more details.
+
+    You should have received a copy of the GNU Affero General Public License
+    along with PerconaFT.  If not, see <http://www.gnu.org/licenses/>.


Some files, e.g. this one, seems to miss Apache license in the header. @spetrunia can we add them?

@siying The license is updated in #7801.

Summary: To be used for implementing Range Locking. Pull Request resolved: facebook#7753 Reviewed By: zhichao-cao Differential Revision: D25378980 Pulled By: cheng-chang fbshipit-source-id: 801a9c5cd92a84654ca2586b73e8f69001e89320

facebook-github-bot added the CLA Signed label Dec 7, 2020

spetrunia mentioned this pull request Dec 7, 2020

Range Locking: Implementation of range locking #7506

Closed

facebook-github-bot reviewed Dec 7, 2020

View reviewed changes

spetrunia force-pushed the spetrunia-range-locking-rocksdb-pr2-lib-dir branch from 21d3578 to 87c00f9 Compare December 7, 2020 21:57

facebook-github-bot reviewed Dec 7, 2020

View reviewed changes

ghost reviewed Dec 8, 2020

View reviewed changes

utilities/transactions/lock/range/range_tree/lib/locktree/treenode.h Outdated Show resolved Hide resolved

ghost reviewed Dec 8, 2020

View reviewed changes

utilities/transactions/lock/range/range_tree/lib/locktree/concurrent_tree.h Outdated Show resolved Hide resolved

spetrunia force-pushed the spetrunia-range-locking-rocksdb-pr2-lib-dir branch from 87c00f9 to b8d17b9 Compare December 8, 2020 22:25

spetrunia force-pushed the spetrunia-range-locking-rocksdb-pr2-lib-dir branch from b8d17b9 to 74dd0de Compare December 8, 2020 22:32

spetrunia force-pushed the spetrunia-range-locking-rocksdb-pr2-lib-dir branch from 74dd0de to f1be51f Compare December 8, 2020 22:38

spetrunia force-pushed the spetrunia-range-locking-rocksdb-pr2-lib-dir branch from f1be51f to 92e4660 Compare December 8, 2020 23:00

facebook-github-bot reviewed Dec 8, 2020

View reviewed changes

spetrunia force-pushed the spetrunia-range-locking-rocksdb-pr2-lib-dir branch from 92e4660 to 24b3d42 Compare December 9, 2020 10:02

LockTree library, originally from PerconaFT

c6fd639

To be used for implementing Range Locking. src.mk, CMakeLists.txt and TARGETS are updated to compile the files from the library.

spetrunia force-pushed the spetrunia-range-locking-rocksdb-pr2-lib-dir branch from 24b3d42 to c6fd639 Compare December 9, 2020 10:41

facebook-github-bot reviewed Dec 9, 2020

View reviewed changes

facebook-github-bot closed this in 98236fb Dec 9, 2020

facebook-github-bot added the Merged label Dec 9, 2020

siying reviewed Dec 15, 2020

View reviewed changes

romanz mentioned this pull request May 20, 2021

librocksdb fails to build on a Raspberry Pi 4 romanz/electrs#403

Closed

ajkr mentioned this pull request Jan 12, 2023

license issue in dbt.cc #11086

Closed

lombarde mentioned this pull request Nov 20, 2023

Potential license issue while using RocksDB through Apache-2.0 license #12079

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LockTree library, originally from PerconaFT #7753

LockTree library, originally from PerconaFT #7753

spetrunia commented Dec 7, 2020

adamretter commented Dec 7, 2020

spetrunia commented Dec 7, 2020

facebook-github-bot left a comment

ghost commented Dec 7, 2020

facebook-github-bot commented Dec 7, 2020

facebook-github-bot left a comment

ghost commented Dec 8, 2020

ghost commented Dec 8, 2020 •

edited by ghost

Loading

spetrunia commented Dec 8, 2020 •

edited

Loading

facebook-github-bot commented Dec 8, 2020

facebook-github-bot commented Dec 8, 2020

facebook-github-bot commented Dec 8, 2020

facebook-github-bot commented Dec 8, 2020

ghost commented Dec 8, 2020

facebook-github-bot left a comment

ghost commented Dec 8, 2020

ghost commented Dec 9, 2020 •

edited by ghost

Loading

facebook-github-bot commented Dec 9, 2020

spetrunia commented Dec 9, 2020 •

edited

Loading

spetrunia commented Dec 9, 2020

facebook-github-bot commented Dec 9, 2020

facebook-github-bot left a comment

facebook-github-bot commented Dec 9, 2020

siying Dec 15, 2020

ghost Dec 22, 2020

LockTree library, originally from PerconaFT #7753

LockTree library, originally from PerconaFT #7753

Conversation

spetrunia commented Dec 7, 2020

adamretter commented Dec 7, 2020

spetrunia commented Dec 7, 2020

facebook-github-bot left a comment

Choose a reason for hiding this comment

ghost commented Dec 7, 2020

facebook-github-bot commented Dec 7, 2020

facebook-github-bot left a comment

Choose a reason for hiding this comment

ghost commented Dec 8, 2020

ghost commented Dec 8, 2020 • edited by ghost Loading

spetrunia commented Dec 8, 2020 • edited Loading

facebook-github-bot commented Dec 8, 2020

facebook-github-bot commented Dec 8, 2020

facebook-github-bot commented Dec 8, 2020

facebook-github-bot commented Dec 8, 2020

ghost commented Dec 8, 2020

facebook-github-bot left a comment

Choose a reason for hiding this comment

ghost commented Dec 8, 2020

ghost commented Dec 9, 2020 • edited by ghost Loading

facebook-github-bot commented Dec 9, 2020

spetrunia commented Dec 9, 2020 • edited Loading

spetrunia commented Dec 9, 2020

facebook-github-bot commented Dec 9, 2020

facebook-github-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Dec 9, 2020

siying Dec 15, 2020

Choose a reason for hiding this comment

ghost Dec 22, 2020

Choose a reason for hiding this comment

ghost commented Dec 8, 2020 •

edited by ghost

Loading

spetrunia commented Dec 8, 2020 •

edited

Loading

ghost commented Dec 9, 2020 •

edited by ghost

Loading

spetrunia commented Dec 9, 2020 •

edited

Loading