Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Legacy and Custom FileWrapper classes from header files #7851

Closed
wants to merge 10 commits into from
Closed

Remove Legacy and Custom FileWrapper classes from header files #7851

wants to merge 10 commits into from

Commits on Jan 26, 2021

  1. Add CustomEnv class 

    And remove LegacyFileSystem from public consumption.
    @mrambacher
    mrambacher committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    ce70eb0 View commit details
    Browse the repository at this point in the history

  2. Add WinFileSystem 

    Make WinEnv into a CompositeEnv
    @mrambacher
    mrambacher committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    473de3d View commit details
    Browse the repository at this point in the history

  3. Fix windows typo

    @mrambacher
    mrambacher committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    af4ba21 View commit details
    Browse the repository at this point in the history

  4. Fix lint issues

    @mrambacher
    mrambacher committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    04c1401 View commit details
    Browse the repository at this point in the history

  5. Fix namespace issues

    @mrambacher
    mrambacher committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    493cbe0 View commit details
    Browse the repository at this point in the history

  6. Remove Legacy and Composite FileWrapper classes from headers 

    Made all of the uses of the Legacy and Composite  FileWrapper classes private.  Since all Env objects have a FileSystem already, most of the Legacy wrapping was adding an extra layer of wrapping.  The Composite classes were already "private" to the CompositeEnv and just needed relocated into a source file.
    @mrambacher
    mrambacher committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    a305966 View commit details
    Browse the repository at this point in the history

  7. Fix merge

    @mrambacher
    mrambacher committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    dd3fd77 View commit details
    Browse the repository at this point in the history

  8. Fix mangled merge

    @mrambacher
    mrambacher committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    ab7f8df View commit details
    Browse the repository at this point in the history

  9. Another Windows Merge Issue

    @mrambacher
    mrambacher committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    f592daf View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Fix lint issues

    @mrambacher
    mrambacher committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    0abbc0a View commit details
    Browse the repository at this point in the history