Extend VerifyFileChecksums API for blob files #7979
Conversation
akankshamahajan15
force-pushed
the
blobdb_verifychecksum
branch
3 times, most recently
from
159ab99
to
fc9dddc
Compare
There was a problem hiding this comment.
@akankshamahajan15 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@akankshamahajan15 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Thanks for the PR @akankshamahajan15 ! LGTM in general, just some minor comments (please see below).
Summary: Extend VerifyFileChecksums API to verify blob files in case of use_file_checksum. Test Plan: New unit test db_blob_corruption_test Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
akankshamahajan15
force-pushed
the
blobdb_verifychecksum
branch
from
4565311
to
f4c7aa4
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@akankshamahajan15 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@akankshamahajan15 merged this pull request in 46cf5fb. |
Summary: Extend VerifyFileChecksums API to verify blob files in case of use_file_checksum. Pull Request resolved: facebook#7979 Test Plan: New unit test db_blob_corruption_test Reviewed By: ltamasi Differential Revision: D26534040 Pulled By: akankshamahajan15 fbshipit-source-id: 7dc5951a3df9d265ea1265e0122b43c966856ade
Summary: Extend VerifyFileChecksums API to verify blob files in case of
use_file_checksum.
Test Plan: New unit test db_blob_corruption_test
Reviewers:
Subscribers:
Tasks:
Tags: