Fixed manifest_dump issues when printing keys and values containing null characters #8378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdillinger
reviewed
Jun 9, 2021
|
You can see CircleCI failed on your test. (The regex does seem so specific that I was afraid it would be fragile.) |
…ll characters directly, which wasnt working properly because of the python subprocess call.
|
The latest CircleCI failures are unrelated to this change |
pdillinger
approved these changes
Jun 10, 2021
…rify that key with null character in it is present in the manifest_dump output.
|
@bjlemaire has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@bjlemaire merged this pull request in d61a449. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed fprintf function to fputc in ApplyVersionEdit, and replaced null characters with whitespaces.
Added unit test in ldb_test.py - verifies that manifest_dump --verbose output is correct when keys and values containing null characters are inserted.