Revert "Snapshot release triggered compaction without multiple tombstones (#8357)" #8410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ones (facebook#8357)" This reverts commit 9167ece.
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jay-zhuang
approved these changes
Jun 15, 2021
jay-zhuang
added a commit
to jay-zhuang/rocksdb
that referenced
this pull request
Jun 22, 2021
…e tombstones (facebook#8357)" (facebook#8410)" This reverts commit 25be1ed.
tabokie
added a commit
to tabokie/rocksdb
that referenced
this pull request
Aug 11, 2022
… multiple tombstones (facebook#8357)" (facebook#8410)" (facebook#8438)" This reverts commit f89423a. Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
to tikv/rocksdb
that referenced
this pull request
Aug 30, 2022
… multiple tombstones (facebook#8357)" (facebook#8410)" (facebook#8438)" This reverts commit f89423a. Signed-off-by: tabokie <xy.tao@outlook.com>
hbisheng
pushed a commit
to hbisheng/rocksdb
that referenced
this pull request
Jul 8, 2024
… multiple tombstones (facebook#8357)" (facebook#8410)" (facebook#8438)" This reverts commit f89423a. Signed-off-by: tabokie <xy.tao@outlook.com>
hbisheng
pushed a commit
to hbisheng/rocksdb
that referenced
this pull request
Aug 22, 2024
… multiple tombstones (facebook#8357)" (facebook#8410)" (facebook#8438)" This reverts commit f89423a. Signed-off-by: tabokie <xy.tao@outlook.com>
v01dstar
added a commit
to v01dstar/rocksdb
that referenced
this pull request
Oct 28, 2024
… multiple tombstones (facebook#8357)" (facebook#8410)" (facebook#8438)" This reverts commit f89423a. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
added a commit
to v01dstar/rocksdb
that referenced
this pull request
Oct 28, 2024
… multiple tombstones (facebook#8357)" (facebook#8410)" (facebook#8438)" This reverts commit f89423a. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
added a commit
to v01dstar/rocksdb
that referenced
this pull request
Oct 28, 2024
… multiple tombstones (facebook#8357)" (facebook#8410)" (facebook#8438)" This reverts commit f89423a. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9167ece.
It was found to reliably trip a compaction picking conflict assertion in a MyRocks unit test. We don't understand why yet so reverting in the meantime.
Test Plan:
make check -j48