Cleanup includes in dbformat.h #8930
Conversation
Do not include files that are not directly needed by this header. Move the includes into the source files requiring them. Do not include dbformat in places it is not required.
util/duplicate_detector.h
Outdated
| @@ -5,7 +5,10 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <cinttypes> | |||
There was a problem hiding this comment.
This header includes things beyond <cstdint> that are not generally needed. Recommend changing all cinttypes to cstdint.
There was a problem hiding this comment.
Updated for this change but there are almost 100 other places that include cinttypes. Will leave that exercise to another day...
There was a problem hiding this comment.
I recently tried changing one and the file used PRIu64 so we can't replace it everywhere.
|
@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@mrambacher has updated the pull request. You must reimport the pull request before landing. |
|
@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: This header file was including everything and the kitchen sink when it did not need to. This resulted in many places including this header when they needed other pieces instead. Cleaned up this header to only include what was needed and fixed up the remaining code to include what was now missing. Hopefully, this sort of code hygiene cleanup will speed up the builds... Pull Request resolved: facebook/rocksdb#8930 Reviewed By: pdillinger Differential Revision: D31142788 Pulled By: mrambacher fbshipit-source-id: 6b45de3f300750c79f751f6227dece9cfd44085d
This header file was including everything and the kitchen sink when it did not need to. This resulted in many places including this header when they needed other pieces instead.
Cleaned up this header to only include what was needed and fixed up the remaining code to include what was now missing.
Hopefully, this sort of code hygiene cleanup will speed up the builds...