Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated overloads of DB::CompactRange #9444

Closed
wants to merge 1 commit into from
Closed

Remove deprecated overloads of DB::CompactRange #9444

wants to merge 1 commit into from

Conversation

akankshamahajan15
Copy link
Contributor

Summary: In RocksDB few overloads of DB::CompactRange() are marked as DEPRECATED_FUNC, and
we are removing it in the upcoming 7.0 release.

Test Plan: CircleCI

@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mrambacher
mrambacher suggested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@mrambacher mrambacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the API also need removed from include/rocksdb/utilities/stackable_db.h ?

@akankshamahajan15
Copy link
Contributor Author

akankshamahajan15 commented Jan 26, 2022 •
edited
Loading

Doesn't the API also need removed from include/rocksdb/utilities/stackable_db.h ?

These deprecated APIs are not present in stackable_db.h
(https://github.com/facebook/rocksdb/blob/main/include/rocksdb/utilities/stackable_db.h). May be they have been removed or were not there.

@mrambacher
Copy link
Contributor

Doesn't the API also need removed from include/rocksdb/utilities/stackable_db.h ?

These deprecated APIs are not present in stackable_db.h (https://github.com/facebook/rocksdb/blob/main/include/rocksdb/utilities/stackable_db.h). May be they have been removed or were not there.

My mistake. I did not realize the number of different signatures for CompactRange and that you were leaving a few signatures.

ajkr
ajkr approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing.

@akankshamahajan15
Remove deprecated overloads of DB::CompactRange
6339264 
Summary: In RocksDB few overloads of DB::CompactRange() are marked as DEPRECATED_FUNC, and
we are removing it in the upcoming 7.0 release.

Test Plan: CircleCI
@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkr ajkr ajkr approved these changes

@mrambacher mrambacher Awaiting requested review from mrambacher

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akankshamahajan15 @facebook-github-bot @mrambacher @ajkr