Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Add BlockBasedTableOptions::filter_construct_corruption to Options::DisableExtraCheck() #9479

Closed
wants to merge 6 commits into from
Closed

[Draft] Add BlockBasedTableOptions::filter_construct_corruption to Options::DisableExtraCheck() #9479

wants to merge 6 commits into from

Commits on Feb 1, 2022

  1. draft

    @hx235
    hx235 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    614dff4 View commit details
    Browse the repository at this point in the history

  2. Experiemnt - partitioned_filters_construction_status_

    @hx235
    hx235 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    495437b View commit details
    Browse the repository at this point in the history

  3. Feeback: add to db_crasjtest.py/rename checksum/safer filter on hash … 

    …entries corruption return/todo for streaming hash entry verification/keep hash entries in AddAllEntries() by default and use list
    @hx235
    hx235 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    49dfa1f View commit details
    Browse the repository at this point in the history

  4. Address feedback 

    Summary:
-add //
-abstact out BuiltinFilterBitsReader and static cast
-specfic API comment related (new) bloom filter
-initialize xor_checksum in-place
-remove unnecesary large write buffer size in test
-bracket initialization of uint64_t from literal
-inject corruption in Finish path
-more realistic subtle corruption in test
    @hx235
    hx235 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    d91c3f8 View commit details
    Browse the repository at this point in the history

  5. Feedback 

    Summary:
-Fix AlwaysTrueFilter length
-Static GetBuiltinFilterBitsReader in BuiltinFilterPolicy
-Fix API comment related to DisableExtraChecks

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
    @hx235
    hx235 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    3935564 View commit details
    Browse the repository at this point in the history

  6. Add filter_construct_corruption to Options::DisableExtraCheck()

    @hx235
    hx235 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    8899644 View commit details
    Browse the repository at this point in the history