Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trivial Javadoc omissions #9534

Closed
wants to merge 2 commits into from
Closed

Fix trivial Javadoc omissions #9534

wants to merge 2 commits into from

Conversation

stefan-zobel
Copy link
Contributor

  • fix spelling of valueSizeSofLimit and add "@param" description in ReadOptions
  • add 3 missing "@return" in RocksDB

@adamretter
Copy link
Collaborator

@stefan-zobel Thanks this LGTML

@jay-zhuang can you merge please?

Copy link
Contributor

@mrambacher mrambacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@stefan-zobel has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants