Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parallel test updates in CI; fbcode LIB_MODE=shared #9553

Closed
wants to merge 1 commit into from
Closed

Fix parallel test updates in CI; fbcode LIB_MODE=shared #9553

wants to merge 1 commit into from

Conversation

pdillinger
Copy link
Contributor

@pdillinger pdillinger commented Feb 11, 2022 •
edited
Loading

Summary:

  • Fix LIB_MODE=shared for Meta-internal builds (use PIC libraries
    appropriately)
  • Fix gnu_parallel to recognize CircleCI and Travis builds as not
    connected to a terminal (was previously relying on the
    | cat_ignore_eagain stuff for Ubuntu 16). This problem could cause
    timeouts that should be 10m to balloon to 5h.

Test Plan: manual and CI

mrambacher
mrambacher reviewed Feb 11, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
build_tools/build_detect_platform Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mrambacher
mrambacher approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@mrambacher mrambacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works in the FB infrastructure (looks like some libraries may be different?), works for me.

build_tools/fbcode_config_platform009.sh
Comment on lines +35 to +36
# location of zlib headers and libraries
ZLIB_INCLUDE=" -I $ZLIB_BASE/include/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These libraries previously where skipped in the PIC case. Is this correct now for FB internal?

@pdillinger
Copy link
Contributor Author

I'm going to see if I can solve the problem of stack traces missing file and line info. One solution appears to be calling gdb rather than addr2line

@facebook-github-bot
Copy link
Contributor

@pdillinger has updated the pull request. You must reimport the pull request before landing.

@pdillinger pdillinger changed the title Enable LIB_MODE=shared by default Fix parallel test updates in CI, fbcode LIB_MODE=shared Feb 12, 2022
@pdillinger pdillinger changed the title Fix parallel test updates in CI, fbcode LIB_MODE=shared Fix parallel test updates in CI; fbcode LIB_MODE=shared Feb 12, 2022
@pdillinger
Copy link
Contributor Author

I'm going to see if I can solve the problem of stack traces missing file and line info. One solution appears to be calling gdb rather than addr2line

I'm reducing the scope of this PR because of this issue. Hopefully fix before long in another PR

@facebook-github-bot
Copy link
Contributor

@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrambacher mrambacher mrambacher approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdillinger @facebook-github-bot @mrambacher