Change enum SizeApproximationFlags to enum class #9604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akankshamahajan15
force-pushed
the
fix_failure
branch
from
a5af530
to
1c9941e
Compare
ajkr
reviewed
Feb 19, 2022
Summary: Change enum SizeApproximationFlags to enum and class and add overloaded operators for the class. Test Plan: Circle CI jobs
akankshamahajan15
force-pushed
the
fix_failure
branch
from
1c9941e
to
d2e625f
Compare
riversand963
approved these changes
Feb 19, 2022
|
ah, Java needs to be fixed too |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Oh yes. Java build is failing. Do we need to add overloading operators as well in Java? |
No, they're optional / for convenience. |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ajkr
added a commit
to ajkr/rocksdb
that referenced
this pull request
Feb 20, 2022
…)" This reverts commit 3699b17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Change enum SizeApproximationFlags to enum and class and add
overloaded operators for the transition between enum class and uint8_t
Test Plan: Circle CI jobs