Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming Compression API for WAL compression. #9619

Closed
wants to merge 9 commits into from

Conversation

sidroyc
Copy link
Contributor

@sidroyc sidroyc commented Feb 22, 2022

Implement a streaming compression API (compress/uncompress) to use for WAL compression. The log_writer would use the compress class/API to compress a record before writing it out in chunks. The log_reader would use the uncompress class/API to uncompress the chunks and combine into a single record.

Added unit test to verify the API for different sizes/compression types.

Copy link
Contributor

@anand1976 anand1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few coding style comments.

util/compression.h Show resolved Hide resolved
util/compression.h Outdated Show resolved Hide resolved
util/compression.h Outdated Show resolved Hide resolved
util/compression.h Outdated Show resolved Hide resolved
util/compression.cc Outdated Show resolved Hide resolved
util/compression.cc Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@sidroyc has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants