Fix TSAN caused by calling rend()
and pop_front()
.
#9698
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
PR9686 makes
WriteToWAL()
callassert(...!=rend())
while not holdingdb mutex or log mutex. Another thread may concurrently call
pop_front()
, causing race condition.To fix, assert only if mutex is held.
Test Plan:
COMPILE_WITH_TSAN=1 make check