Fix make clean fail after java build #9710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1216,7 +1216,7 @@ clean-rocks: | |||
| $(FIND) . -name "*.[oda]" -exec rm -f {} \; | |||
| $(FIND) . -type f -regex ".*\.\(\(gcda\)\|\(gcno\)\)" -exec rm -f {} \; | |||
|
|
|||
| clean-rocksjava: | |||
| clean-rocksjava: clean-rocks | |||
There was a problem hiding this comment.
Error message related to this fix?
There was a problem hiding this comment.
Here is the error message, it return error code 2 (find and delete failed because dir jl is just deleted by clean-rocksjava:
$ make rocksdbjava && make clean
...
find . -name "*.[oda]" -exec rm -f {} \;
cd java && /Library/Developer/CommandLineTools/usr/bin/make clean
find: ./jl: No such file or directory
rm -rf ./include
rm -rf test-libs
rm -rf target
make: *** [clean-rocks] Error 1
make: *** Waiting for unfinished jobs....
...
riversand963
approved these changes
Mar 24, 2022
|
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Seems clean-rocksjava and clean-rocks conflict. Also remove unnecessary step in java CI build, otherwise it will rebuild the code again as java make sample do clean up first. Test Plan: `make rocksdbjava && make clean` should return success
jay-zhuang
force-pushed
the
java_build_minor_fix
branch
from
1381545
to
586711d
Compare
|
@jay-zhuang has updated the pull request. You must reimport the pull request before landing. |
|
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems clean-rocksjava and clean-rocks conflict.
Also remove unnecessary step in java CI build, otherwise it will rebuild
the code again as java make sample do clean up first.
Test Plan:
make rocksdbjava && make cleanshould return success