Do not release and re-acquire dbmutex on memtable-switch if no listener #9758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks @jay-zhuang for the review! |
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ti-chi-bot bot
pushed a commit
to tikv/tikv
that referenced
this pull request
Oct 9, 2024
close #17617 Upgrade RocksDB to 8.10 * Deprecate RocksEngineIterator::sequence() * Deprecate seq in CompactionFilter, since it is no longer used by TiKV * Some statistics have been removed from RocksDB, accommodate that change in TiKV * Dynamic_level_bytes is now default true, some tests are modified to reflect this change * Removing test_rocksdb_listener, because facebook/rocksdb#9758 overwrited tikv/rocksdb#347, and the test is only for raftstore v2 which is not being used. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to release-and-acquire immediately when no listener is registered. This is
what we have been doing for
NotifyOnFlushBegin(),NotifyOnFlushCompleted(),NotifyOnCompactionBegin(),NotifyOnCompactionCompleted(), and some otherNotifyOnXXmethods in event_helpers.cc.Do the same for
NotifyOnMemTableSealed ().Test plan:
make check