Disallow commit-time-batch for write-prepared/write-unprepared txn conditionally

[riversand963]

For write-prepared/write-unprepared transactions,
GetCommitTimeWriteBatch() can be used only if the transaction is started
with TransactionOptions::use_only_the_last_commit_time_batch_for_recovery set
to true. Otherwise, it is possible that multiple uncommitted versions of the
same key exist in the database. During bottommost compaction, RocksDB may
set the sequence numbers of both to zero once they become committed, causing
output SST file to have two identical internal keys.

Test plan:
make check
pay special attention to the following

transaction_test --gtest_filter=MySQLStyleTransactionTest/MySQLStyleTransactionTest.TransactionStressTest/*

Apply the following test patch

index 36b2e9ec4..1f1d96d27 100644
--- a/test_util/transaction_test_util.cc
+++ b/test_util/transaction_test_util.cc
@@ -212,7 +212,7 @@ bool RandomTransactionInserter::DoInsert(DB* db, Transaction* txn,
         ROCKS_LOG_DEBUG(db->GetDBOptions().info_log,
                         "Prepare of %" PRIu64 " %s (%s)", txn->GetId(),
                         s.ToString().c_str(), txn->GetName().c_str());
-        if (rand_->OneIn(20)) {
+        if (true || rand_->OneIn(20)) {
           // This currently only tests the mechanics of writing commit time
           // write batch so the exact values would not matter.
           s = txn_->GetCommitTimeWriteBatch()->Put("cat", "dog");

and then run tests multiple times

TEST_TMPDIR=/dev/shm/ ~/gtest-parallel/gtest-parallel -r 1024 -w 64 ./transaction_test --gtest_filter=*MySQLStyleTransactionTest.TransactionStressTest/5

Before this fix, the above command has quite high probability to fail. After the fix, all tests pass consistently.

[facebook-github-bot]

@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@riversand963 has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[lth]

Looks good to me.

[facebook-github-bot]

@riversand963 has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@riversand963 has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@riversand963 has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.