Skip to content

add NULL pointer check in util.c #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2019
Merged

add NULL pointer check in util.c #1706

merged 1 commit into from
Aug 5, 2019

Conversation

LeeYoung624
Copy link
Contributor

@LeeYoung624 LeeYoung624 commented Jul 29, 2019 •
edited
Loading

I believe the original code was meant to deal with case that /proc/cpuinfo has come across a error: the formatting of /proc/cpuinfo was broken. In that way, the sep could also be NULL because it's the return of strchr.
I think adding a NULL check is better here.

@Cyan4973
Copy link
Contributor

Good point @LeeYoung624 !

@Cyan4973 Cyan4973 self-assigned this Aug 4, 2019
@Cyan4973 Cyan4973 merged commit 2635107 into facebook:dev Aug 5, 2019
@felixhandte felixhandte mentioned this pull request Aug 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees

@Cyan4973 Cyan4973

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeeYoung624 @Cyan4973 @facebook-github-bot