Added support for vertical alignments per fbia documentation: https:/… #117
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Conflicts: tests/Facebook/InstantArticles/Elements/InstantArticleTest.php tests/Facebook/InstantArticles/Elements/Validators/InstantArticleValidatorTest.php
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
|
Hey! Thanks for this @dodozhang21 ! Im checking here, the travis-ci is complaining about few things on code. You can check here and Ill also add few inline comments. Can you check these so we can have it merged? |
|
@everton-rosario I'm pretty sure I had those fixed already. The build is passing now right? |
This PR