Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Update deps_common.sh, please #5

Closed
trosan opened this issue Dec 19, 2017 · 1 comment
Closed

Update deps_common.sh, please #5

trosan opened this issue Dec 19, 2017 · 1 comment

Comments

@trosan
Copy link

trosan commented Dec 19, 2017

Issue Description

The current dependency install script seems to be out of date.
I experienced the following issues:

  • THRIFT_COMPILER_INCLUDE was set to NOTFOUND and I had to manually download the ThriftLibrary.cmake since the current script points to a tag that does not contain this script (and had to set to that path manually - how is it supposed to be set?)
  • Afterwards PROTOCOL and TRANSPORT are still set to NOTFOUND and I have no clue as to which libraries these are.

Environment

  • master branch, latest commit b542717
  • OS version: ubuntu-16.04
    ...

Minimal test code / Steps to reproduce the issue

  • setup clean ubuntu 16.04 vm, clone git, run deps_ubuntu_16.04.sh, run "cmake .."

What's the actual result?

  • "CMake Error at CMakeLists.txt:32 (include):
    include could not find load file:

    THRIFT_COMPILER_INCLUDE-NOTFOUND/thrift/ThriftLibrary.cmake

    CMake Error at CMakeLists.txt:40 (thrift_object):
    Unknown CMake command "thrift_object".

    -- Configuring incomplete, errors occurred!
    See also "/home/c1/fbzmq/fbzmq/build/CMakeFiles/CMakeOutput.log"."

and:

  • "CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
    Please set them or make sure they are set and tested correctly in the CMake files:
    PROTOCOL
    linked by target "fbzmq" in directory /home/c1/fbzmq/fbzmq
    TRANSPORT
    linked by target "fbzmq" in directory /home/c1/fbzmq/fbzmq"

What's the expected result?

  • cmake should run without errors
facebook-github-bot pushed a commit to facebook/openr that referenced this issue Jan 12, 2018
Summary:
to fix this [issue](facebookarchive/fbzmq#5) i'm making the build script here
more like the one in openr.

Reviewed By: saifhhasan

Differential Revision: D6710610

fbshipit-source-id: 300b9fca10a1d0096317f5dce4b3f9ac69dd61ae
@jstrizich
Copy link
Contributor

Sorry for the delay. We've updated the build script and directions for it in the top level readme. Please let us know if there are still issues and always feel free to put up a pull request with fixes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants