Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Example tests #20

Closed
simenbrekken opened this issue Aug 5, 2014 · 18 comments
Closed

Example tests #20

simenbrekken opened this issue Aug 5, 2014 · 18 comments

Comments

@simenbrekken
Copy link

It would be great if the examples included a few (Jest) test cases. Preferably test cases that deal with both components and stores.

@nobodyguy
Copy link

Yeah, I was thinking about the same 👍

@justinbelcher
Copy link

👍

@fisherwebdev
Copy link
Contributor

Yes, this was something I was thinking about for a code example and blog
post. Hoping to get to this idea and also a blog post about immutable data
in the coming week or two.
On Aug 8, 2014 10:20 PM, "Justin Belcher" notifications@github.com wrote:

[image: 👍]


Reply to this email directly or view it on GitHub
#20 (comment).

@justinbelcher
Copy link

Probably too specific for a blog post, but one thing I've found tricky/messy is testing Store functions that don't emit change events. And for those that do, making Jest wait until the action has processed to verify behavior.

@nobodyguy
Copy link

@fisherwebdev I think it's perfect topic for a blog post and immutable data also sounds great!

@sunnyrjuneja
Copy link
Contributor

👍

@dmitrig01
Copy link

👍 :-)

@lenage
Copy link

lenage commented Aug 23, 2014

👍

6 similar comments
@cirocosta
Copy link

👍

@iest
Copy link

iest commented Sep 13, 2014

👍

@naoufal
Copy link

naoufal commented Sep 16, 2014

👍

@marco-loche
Copy link

👍

@AlbanMinassian
Copy link

👍

@dariocravero
Copy link

👍

@sunnyrjuneja
Copy link
Contributor

@fisherwebdev thanks bill! probably can close this issue tho.

@justin808
Copy link
Contributor

@fisherwebdev Did you add docs on how to run the tests, and should they be passing? I just pulled the lastest and get errors running npm test from the example directories. Should I open a new issue for this?

@cirocosta
Copy link

@justin808 this is somewhat related to #68 regarding documenting the build process for the examples. For running the examples test one needs to actually go into the example's folder, install dependencies and then run the tests (e.g,cd examples/flux-chat && npm install && npm test && cd ...). This is needed as the intention was (i suspect) to not agglomerate unrelated dependencies (which is the expected).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests