This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Add option to not cache source code. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -90,7 +92,7 @@ class Module { | |||
| } | |||
|
|
|||
| getDependencies(transformOptions) { | |||
| return this.read(transformOptions).then(data => data.dependencies); | |||
| return this.read(transformOptions).then(({dependencies}) => dependencies); | |||
There was a problem hiding this comment.
this is longer and contains more syntax ;-)
There was a problem hiding this comment.
just made it consistent with the other methods in this file :)
There was a problem hiding this comment.
I don’t actually care, just couldn’t resist commenting :D
|
lgtm. sorry for not responding, I was on pto |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some repositories it is not possible to store (or
JSON.stringify) every file's source code and transformed output. Node.js will actually run out of memory and crash.Some clients of node-haste might not need this at all. I made the least invasive change I could – add an option that determines what should be cached for a module. It is by default enabled, so a new release of node-haste should be fully backwards compatible.
Later we may have to implement a better way of caching transformed files. We might want to do what Jest does and create one output file per input file. In the meantime, this will suffice :)