fix: make dark style of navbar properly #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
commented
Sep 30, 2021
| @@ -156,15 +156,17 @@ html[data-theme='dark'], | |||
|
|
|||
| &--dark { | |||
| --ifm-navbar-background-color: #242526; | |||
| --ifm-menu-color-background-active: rgba(255, 255, 255, 0.05); | |||
There was a problem hiding this comment.
Increased contrast for active link background to make it more visible.
| @@ -169,7 +169,7 @@ | |||
| </a> | |||
| <button type="button" class="clean-btn navbar-sidebar__close"> | |||
| <svg viewBox="0 0 413.348 413.348" width="20" height="20"> | |||
| <path d="m413.348 24.354-24.354-24.354-182.32 182.32-182.32-182.32-24.354 24.354 182.32 182.32-182.32 182.32 24.354 24.354 182.32-182.32 182.32 182.32 24.354-24.354-182.32-182.32z"/> | |||
| <path fill="currentColor" d="m413.348 24.354-24.354-24.354-182.32 182.32-182.32-182.32-24.354 24.354 182.32 182.32-182.32 182.32 24.354 24.354 182.32-182.32 182.32 182.32 24.354-24.354-182.32-182.32z"/> | |||
There was a problem hiding this comment.
Using current color for close button to consistency with toggle button (seems better).
Dist CSS Diffdiff --git a/packages/core/dist/css/default/default.css b/packages/core/dist-branch/css/default/default.css
index 553f0d9..c5ab10d 100644
--- a/packages/core/dist/css/default/default.css
+++ b/packages/core/dist-branch/css/default/default.css
@@ -2499,7 +2499,7 @@ html[data-theme='dark'],
}
.navbar__brand:hover {
- color: inherit;
+ color: var(--ifm-navbar-link-hover-color);
text-decoration: none;
}
@@ -2571,16 +2571,18 @@ html[data-theme='dark'],
.navbar--dark {
--ifm-navbar-background-color: #242526;
+ --ifm-menu-color-background-active: rgba(255, 255, 255, 0.05);
--ifm-navbar-link-color: var(--ifm-color-gray-100);
--ifm-navbar-link-hover-color: var(--ifm-color-primary);
--ifm-navbar-search-input-background-color: rgba(255, 255, 255, 0.1);
--ifm-navbar-search-input-color: var(--ifm-color-white);
--ifm-navbar-search-input-placeholder-color: rgba(255, 255, 255, 0.5);
--ifm-menu-color: var(--ifm-color-gray-300);
- --ifm-navbar-toggle-color: var(--ifm-color-white);
}
-.navbar--dark .navbar__toggle {
+.navbar--dark .navbar__toggle,
+ .navbar--dark .navbar-sidebar__close,
+ .navbar--dark .navbar-sidebar__back {
color: var(--ifm-color-white);
}
|
|
Size Change: +916 B (0%) Total Size: 566 kB
ℹ️ View Unchanged
|
|
✔️ Deploy Preview for infima ready! 🔨 Explore the source changes: 9c82026 🔍 Inspect the deploy log: https://app.netlify.com/sites/infima/deploys/6155c7f114f1d1000817941c 😎 Browse the preview: https://deploy-preview-179--infima.netlify.app/demo |
facebook-github-bot
added
the
CLA Signed
|
thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs reported in the comment facebook/docusaurus#3937 (comment)