--Enable saving of edited attributes configs to json #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jturner65
force-pushed
the
MM_SaveConfigJSON
branch
5 times, most recently
from
b5468dd
to
6f95565
Compare
jturner65
force-pushed
the
MM_SaveConfigJSON
branch
5 times, most recently
from
2e6eacc
to
bdc806e
Compare
jturner65
force-pushed
the
MM_SaveConfigJSON
branch
5 times, most recently
from
18aaf59
to
725eb31
Compare
jturner65
force-pushed
the
MM_SaveConfigJSON
branch
3 times, most recently
from
8dd4633
to
4b23541
Compare
jturner65
changed the title
jturner65
force-pushed
the
MM_SaveConfigJSON
branch
from
ac5917d
to
cb41dd2
Compare
jturner65
requested review from
eundersander and
aclegg3
and removed request for
aclegg3
jturner65
force-pushed
the
MM_SaveConfigJSON
branch
3 times, most recently
from
e00c5b5
to
4354aa5
Compare
jturner65
changed the title
This enables root-level attributes to have custom handling so they only write what is expected to json.
jturner65
force-pushed
the
MM_SaveConfigJSON
branch
from
c8b605a
to
08a2b37
Compare
jturner65
changed the title
aclegg3
approved these changes
Oct 7, 2021
src/esp/core/Configuration.h
Outdated
| @@ -156,6 +157,11 @@ class ConfigValue { | |||
|
|
|||
| bool isValid() const { return _type != ConfigStoredType::Unknown; } | |||
|
|
|||
| /** | |||
| * @brief Write this ConfigValue to an appropriately configure json object. | |||
JuanTheEngineer
pushed a commit
that referenced
this pull request
Oct 8, 2021
* --move AbstractFileBasedManagedObject to its own file * --add function stubs to save a ManagedFileBasedObject to JSON * --appropriately configure document for saving. * --enable retrieval of File-based attributes extension from manager. * --properly write json files to disk. * --store spotlight values in subconfiguration of light instances * --move Configuration json load/save code from io::json to Configuration * --update test to ref actual files for stage & object render asset verify * break up json config mapping to have separate value and config procs This enables root-level attributes to have custom handling so they only write what is expected to json. * --move mesh-type handling to attributesBase * --fix orientation bug. write value to json with different tag than key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR enables the saving of user-modified JSON configuration files to disk. All the functionality is complete, and a test for reading and verifying physics manager attributes values passes. All tests that test json strings now also save configs based on those strings, and then reload them and verify they are unchanged in AttributesManagerTest.
How Has This Been Tested
Locally C++ and python tests
Types of changes
Checklist