Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Franka download #1837

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Add Franka download #1837

merged 2 commits into from
Aug 26, 2022

Conversation

laikhtewari
Copy link
Contributor

@laikhtewari laikhtewari commented Aug 25, 2022 •
edited
Loading

Motivation and Context

Given new examples using the franka robot in habitat lab, the download utility was updated to include the source for the franka panda URDF model

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 25, 2022
aclegg3
aclegg3 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@laikhtewari laikhtewari marked this pull request as ready for review August 25, 2022 22:04
@aclegg3 aclegg3 merged commit 113c3f1 into facebookresearch:main Aug 26, 2022
This was referenced Aug 30, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laikhtewari @aclegg3 @facebook-github-bot