Add skinning support for gfx-replay and legacy replay rendering. #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
| @@ -150,9 +158,9 @@ bool fromJsonValue(const JsonGenericValue& obj, | |||
| metadata::attributes::ObjectInstanceShaderType& x) { | |||
| std::string shaderTypeToUseString; | |||
| // read as string | |||
| bool shaderTypeSucceess = fromJsonValue(obj, shaderTypeToUseString); | |||
| bool shaderTypeSuccess = fromJsonValue(obj, shaderTypeToUseString); | |||
There was a problem hiding this comment.
Thanks for fixing all the spelling typos!
| @@ -945,5 +938,40 @@ void BulletPhysicsManager::removeRigidConstraint(int constraintId) { | |||
| } | |||
| } | |||
|
|
|||
| void BulletPhysicsManager::instantiateSkinnedModel( | |||
There was a problem hiding this comment.
@aclegg3 maybe you wanna take a look at changes to BulletPhysicsManager.
jturner65
reviewed
Oct 2, 2023
| /** | ||
| * @brief The next available unique ID for instantiated rigs. | ||
| */ | ||
| int _nextRigInstanceID = 0; |
There was a problem hiding this comment.
In the future we could revisit this so that it managed IDs similar to how PhysicsManager does, reusing freed IDs instead of just incrementing, on the off chance that the RigManager may persist through billions of training cycles.
jturner65
approved these changes
Oct 2, 2023
|
FYI - Tests were passing prior to rebasing to main due to our CI image losing support.
The last run was green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This changeset adds support for:
Capture from the SIRo sandbox tool, which renders using the classic replay renderer:
fetch-2023-09-29_19.20.31.mp4
How it works
Overview
This changeset introduces a new structure,
Rig, which contains a node for each bone of a skinned model. During asset instantiation, theRigis associated to the model instance so that it can be posed during rendering.Therefore, the skinned model is animated by modifying transforms of the
Rigbone nodes. This is currently done in either of those ways:rigUpdate.posein gfx-replay keyframes.Gfx-replay
Two new keyframe fields are introduced:
Additionally, RenderAssetCreationInfo now has a rigId field.
How Has This Been Tested
Types of changes
Checklist