Improve physics object library loading #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om physics config file
facebook-github-bot
added
the
CLA Signed
mosra
reviewed
Sep 26, 2019
eundersander
pushed a commit
to eundersander/habitat-sim
that referenced
this pull request
Aug 6, 2020
Fix wrong return type of SimulatorTaskAction.step
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
* Enable directory loading and global filepaths in object lib loader from physics config file * Pulled Corrade module commit to get isDirectory * Refactor with Corrade Utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change improves object library loading from physics config file by allowing loading of entire directories of objects and allowing all paths to be either relative or global. This PR updates Corrade submodule to access new utility functions.
Note: The mesh references inside a physics object properties file (e.g. "cheezit.phys_properties.json") can already be either relative or global since PR #231. This change affects the paths specified inside the global physics config file (e.g. "default.phys_scene_config.json").
How Has This Been Tested
Local testing with global file paths and directories of objects.
Types of changes
Checklist