Physics usability improvements #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows absolute filenames to be used inside the JSON configs.
…e a lot. Now you can't *see* it runs 60 FPS but you can *feel* it.
* Use an absolute default path so it doesn't depend on current working directory. * Instead of dying on an assert inside rapidjson, check file existence and fail gracefully with a clear message. * Use consistent naming scheme for the options.
So warn on that. People *might* still want to do this, so not making this a hard error.
When all files fail to load, it would crash because of a modulo with zero. When physics is not enabled, the O key would silently do nothing.
facebook-github-bot
added
the
CLA Signed
aclegg3
reviewed
Sep 20, 2019
mosra
commented
Sep 20, 2019
| << ":\n---\nPhysics was enabled and Bullet physics engine was " | ||
| "specified, but the project is built without Bullet support. " | ||
| "Objects added to the scene will be restricted to kinematic updates " | ||
| "only. Reinstall with --bullet to enable Bullet dynamics.\n---"; |
There was a problem hiding this comment.
with --with-bullet? :)
Looking again, this error was actually there, but so buried among the others that I didn't see it. Now it is nicely loud and clear.
This was referenced Sep 25, 2019
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
* Name the Bullet-enabling var consistently, turn it into a CMake option. * assets: use proper directory joining for physics object filenames. * This allows absolute filenames to be used inside the JSON configs. * viewer: printing this every frame actually slows everything down quite a lot. Now you can't *see* it runs 60 FPS but you can *feel* it. * viewer: improve the physics config file passing. * Use an absolute default path so it doesn't depend on current working directory. * Instead of dying on an assert inside rapidjson, check file existence and fail gracefully with a clear message. * Use consistent naming scheme for the options. * viewer: exiting after an error shouldn't use a success return code. * viewer: improve usability of the banana throwing. When all files fail to load, it would crash because of a modulo with zero. When physics is not enabled, the O key would silently do nothing. * viewer: enable at least a bit of MSAA for prettier screenshots. * Changed no Bullet WARNING in ResourceManager to be more helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Sweeps away a bunch of roadblocks I ran into when crafting screenshots for #152.
setup.pyat all (i.e., me). Not a user-facing change as the publicsetup.pyvariable is still named the same./home/mosra/Data/fair/1199943_collision.glb) without those being turned into./data//home/mosra/Data/fair/1199943_collision.glb.--enable-physicsw/o Bullet enabled is most probably an error, so warn on that. People might still want to do this, so not making this a hard error. (Alternatively,--enable-physicscould be compiled out when Bullet is not enabled, if that makes more sense for you.)How Has This Been Tested
Creating those screenshots was quite a soak test for all the viewer functionality, and it survived.