Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --model argument for model selection #60

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

abhimskywalker
Copy link
Contributor

This should close: #59

I tried parsing a few PDFs with small version but it gave MISSING_PAGE on some of the pages, while the base model was able to convert the pages perfectly.

So adding this support for model selection at cli level to help both myself and others. :)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2023
@abhimskywalker
Copy link
Contributor Author

Closes #59

@lukas-blecher
Copy link
Contributor

Sounds good.
I'm a bit worried about backward compatibility though. Maybe instead of redownloading the small model, we can check if the old format is present and then move it to the correct spot?

@lukas-blecher lukas-blecher merged commit 333561d into facebookresearch:main Sep 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for model tag selection in cli --model
3 participants