Skip to content

fix clone type issue #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix clone type issue #179

wants to merge 2 commits into from

Conversation

yifita
Copy link

@yifita yifita commented Apr 30, 2020 •
edited
Loading

a quick fix for the clone issue

fixes #178

@facebook-github-bot
Copy link
Contributor

Hi @yifita!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 30, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@nikhilaravi
Copy link
Contributor

nikhilaravi commented Apr 30, 2020 •
edited
Loading

Can you please add a test which checks the case you mention in the issue? i.e. create a child class and then check the cloned child class has a correct type?

@nikhilaravi nikhilaravi self-assigned this Apr 30, 2020
facebook-github-bot
facebook-github-bot reviewed May 5, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhilaravi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request May 6, 2020
@facebook-github-bot
fix clone type issue (#179)
9c5ab57 
Summary:
a quick fix for the clone issue

fixes #178
Pull Request resolved: #179

Reviewed By: bottler

Differential Revision: D21414309

Pulled By: nikhilaravi

fbshipit-source-id: 359d7724aa5d78bc88a0a9ffc05e6041056e3b3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees

@nikhilaravi nikhilaravi

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lighting clone returns hardcoded class type - prohibits inheritance
3 participants
@yifita @facebook-github-bot @nikhilaravi