Update bundle_adjustment.ipynb #81
Conversation
*: Fixed references to colors in the diagram
|
Hi @trbarron! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks for making this fix. |
Made blue -> orange and green -> purple
|
@trbarron looks good! I'll merge this PR. |
There was a problem hiding this comment.
@nikhilaravi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: *: Fixed references to colors in the diagram Pull Request resolved: #81 Reviewed By: bottler Differential Revision: D20064048 Pulled By: nikhilaravi fbshipit-source-id: a70ee446f1223ec900072a2380c75ed95fb4431d
* commit 'f358b9b14dbc1414c588f308b35f55705d777873': Fix squared distance for CPU impl. (facebookresearch#83) allow changes to background_color in BlendParams (facebookresearch#64) cpu wheel builds for linux and mac Update bundle_adjustment.ipynb (facebookresearch#81) CI updates fix docstring of mesh edge loss
*: Fixed references to colors in the diagram