Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update text in Tutorial 2 per issue #27 #31

Merged
merged 4 commits into from
Dec 17, 2021
Merged

update text in Tutorial 2 per issue #27 #31

merged 4 commits into from
Dec 17, 2021

Conversation

vshobha
Copy link
Contributor

@vshobha vshobha commented Dec 16, 2021 •
edited
Loading

Motivation and Context

Updating text in Tutorial 2 to better reflect the concept illustrated -- only differentiating through TheseusLayer rather than Theseus NLLS optimizers. Addresses issue #27.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 16, 2021
@mhmukadam mhmukadam added the documentation Improvements or additions to documentation label Dec 17, 2021
@mhmukadam mhmukadam added this to the 0.1.0-b.2 milestone Dec 17, 2021
@mhmukadam mhmukadam merged commit 4699b4d into main Dec 17, 2021
@mhmukadam mhmukadam deleted the shobha.2021.12.16.tutorial2 branch December 17, 2021 19:00
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@vshobha @mhmukadam
update text in Tutorial 2 per issue facebookresearch#27 (facebookrese…
c75ad99 
…arch#31)

* update text in Tutorial 2 per issue facebookresearch#27

Co-authored-by: Shobha Venkataraman <shobha@devfair0431.h2.fair>
Co-authored-by: Mustafa Mukadam <mukadam.mh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

@luisenp luisenp Awaiting requested review from luisenp

@bamos bamos Awaiting requested review from bamos

Assignees

@vshobha vshobha

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.1.0-b.2
Development

Successfully merging this pull request may close these issues.
3 participants
@vshobha @mhmukadam @facebook-github-bot