Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge infos results for truncated backward modes #83

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Merge infos results for truncated backward modes #83

merged 3 commits into from
Feb 21, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Feb 14, 2022

Motivation and Context

Closes #44

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@luisenp luisenp added the bug Something isn't working label Feb 14, 2022
@luisenp luisenp self-assigned this Feb 14, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2022
@luisenp
Copy link
Contributor Author

luisenp commented Feb 14, 2022

When reviewing, it'll probably be easier to see changes for each commit separately. The first commit adds the new feature, and the second just moves everything to a new method.

@luisenp luisenp merged commit d8d3eac into main Feb 21, 2022
@luisenp luisenp deleted the lep.merge_infos_truncated_optim branch February 21, 2022 16:56
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Merge infos results for truncated backward modes (facebookresearch#83)
a4ced0a 
* Added code to merge error histories and best solutions when using truncated backward modes.

* Added separate method to encapsulate merge code.

* Added warning for backward_num_iterations > max_iterations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

@bamos bamos Awaiting requested review from bamos

Assignees

@luisenp luisenp

Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decide how the infos should be merged in implicit/truncated modes
3 participants
@luisenp @mhmukadam @facebook-github-bot