Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZeroMQ Topics Support. #730

Merged
merged 1 commit into from
Dec 18, 2022
Merged

ZeroMQ Topics Support. #730

merged 1 commit into from
Dec 18, 2022

Conversation

bonkuraps
Copy link
Contributor

@bonkuraps bonkuraps commented Aug 21, 2022 •
edited
Loading

ZMQ: Add topics filtering

  • Add ZeroMQ topics support.
  • Add ZeroMQ test publisher.
  • Add requirements.txt

Issue: #705

How to test:

cd <plot_juggler_repo>/plotjuggler_plugins/DataStreamZMQ/utilities
./start_test_publisher.py --topic my_topic

Then in the app specify topics separated by either ; or ,

Screenshot 2022-09-25 at 15 39 59

@bonkuraps bonkuraps force-pushed the feature/zeromq-topics-support branch 2 times, most recently from 76051a5 to b830e75 Compare August 21, 2022 10:34
@bonkuraps

This comment was marked as outdated.

Sign in to view
@lgtm-com
Copy link

lgtm-com bot commented Aug 21, 2022

This pull request introduces 1 alert when merging b830e75 into c559f91 - view on LGTM.com

new alerts:

  • 1 for Constant return type on member

@bonkuraps bonkuraps force-pushed the feature/zeromq-topics-support branch from b830e75 to eea647e Compare August 21, 2022 16:33
@bonkuraps bonkuraps mentioned this pull request Aug 21, 2022
Open
@facontidavide
Copy link
Owner

Thanks for contributing. I will be away from the computer for the next 2 weeks. I will review this PR afterward.

I probably prefer ";" as separator

@bonkuraps
Copy link
Contributor Author

bonkuraps commented Aug 22, 2022 •
edited
Loading

Thanks for contributing. I will be away from the computer for the next 2 weeks. I will review this PR afterward.

I probably prefer ";" as separator

Sure, sounds good!

Have a nice vacation then I guess? :)

@bonkuraps bonkuraps force-pushed the feature/zeromq-topics-support branch from f4d2147 to 6d83ad0 Compare August 22, 2022 10:53
@bonkuraps
Copy link
Contributor Author

@facontidavide
Hope you had great vacations, any input on this one? :)

@facontidavide
Copy link
Owner

Would you please provide a longer description of what this PR does, including screenshots?
I am collapsed with work and that would save me some time 😅

@bonkuraps bonkuraps force-pushed the feature/zeromq-topics-support branch 3 times, most recently from c00adf7 to b8ad01a Compare September 25, 2022 13:06
@bonkuraps bonkuraps changed the title [WIP] - ZeroMQ Topics Support. ZeroMQ Topics Support. Sep 25, 2022
@bonkuraps
Copy link
Contributor Author

@facontidavide
I've updated the description and PR is ready for review.
I also recorded the functionality in action but the file got so big that I needed to upload it to Google Drive 😕

@bonkuraps bonkuraps marked this pull request as ready for review September 25, 2022 13:43
@bonkuraps
ZMQ: Add topics filtering
c285755 
- Add ZeroMQ topics support.
- Add ZeroMQ publisher in /utilities.
- Add requirements.txt
@bonkuraps
Copy link
Contributor Author

explore the regex with: https://regex101.com/r/Ktgw7j/1

@bonkuraps
Copy link
Contributor Author

@facontidavide any thoughts on this one? :)

@facontidavide facontidavide merged commit db90f70 into facontidavide:main Dec 18, 2022
@nealwang123
Copy link

I used the 3.6.0 installation on windows and did not find an option for zeromq to filter themes.
image

@nealwang123
Copy link

I used the 3.6.0 installation on windows and did not find an option for zeromq to filter themes. image

Sorry, I just found out that the filter topic feature is added in version 3.6.1. I am compiling it with vcpkg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bonkuraps @facontidavide @nealwang123