Skip to content

bugfix/ignore-base-for-download #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

BluePsyduck
Copy link
Member

Fixed an issue where the "base" mod may actually get downloaded from the mod portal, what should never happen.

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #36 (bd85635) into master (b9f6b45) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #36   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       338       341    +3     
===========================================
  Files             70        70           
  Lines           1074      1081    +7     
===========================================
+ Hits            1074      1081    +7     
Impacted Files Coverage Δ
src/Service/ModDownloadService.php 100.00% <100.00%> (ø)
src/Service/ModFileService.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f6b45...bd85635. Read the comment docs.

@BluePsyduck BluePsyduck merged commit 5c682f3 into master Jun 15, 2021
@BluePsyduck BluePsyduck deleted the bugfix/ignore-base-for-download branch June 15, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant