Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating code to Python 3 #308

Merged
merged 3 commits into from
Nov 2, 2019
Merged

Updating code to Python 3 #308

merged 3 commits into from
Nov 2, 2019

Conversation

gyermolenko
Copy link
Contributor

@gyermolenko gyermolenko commented Nov 2, 2019

Per discussion in #208

This is definitely not every change I wanted to make regarding py2/3.
And I plan to continue related work in separate PRs.

@codecov-io
Copy link

codecov-io commented Nov 2, 2019

Codecov Report

Merging #308 into master will increase coverage by 4.37%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   32.46%   36.83%   +4.37%     
==========================================
  Files          42       38       -4     
  Lines        1534     1352     -182     
==========================================
  Hits          498      498              
+ Misses       1036      854     -182
Impacted Files Coverage Δ
patterns/behavioral/registry.py 0% <ø> (ø)
patterns/structural/flyweight_with_metaclass.py 0% <ø> (ø)
patterns/behavioral/chain_of_responsibility.py 0% <ø> (ø)
patterns/other/blackboard.py 0% <ø> (ø)
patterns/structural/flyweight.py 0% <ø> (ø)
patterns/creational/pool.py 50% <0%> (+4.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c876d...071c3dd. Read the comment docs.

@faif faif merged commit 8fba959 into faif:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants