Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monit config #896

Merged
merged 2 commits into from
Dec 30, 2014
Merged

Monit config #896

merged 2 commits into from
Dec 30, 2014

Conversation

szepeviktor
Copy link
Member

@yarikoptic
Copy link
Member

great. changelog entry and THANKS? :-)

@szepeviktor
Copy link
Member Author

I'd skip THANKS.

@szepeviktor
Copy link
Member Author

...or is it rather an enhancement?

yarikoptic added a commit that referenced this pull request Dec 30, 2014
@yarikoptic yarikoptic merged commit 35766e7 into fail2ban:master Dec 30, 2014
@yarikoptic
Copy link
Member

Thanks! It is a new feature since we had no monit config yet at all ;)

@szepeviktor
Copy link
Member Author

It is a surprise that even a single byte from me is merged.
I am a much like a debugger not a developer.

@yarikoptic
Copy link
Member

I am sorry @szepeviktor -- what keystroke? ;)

@szepeviktor
Copy link
Member Author

I could write a single byte ...

  1. I do not speak python 2. my code quality is not so high.

@yarikoptic
Copy link
Member

Ah -- then I could just say "welcome to the team!" Persuasion and desire is at times even more important that being a kool hazker ;) and you are already in the first third (git shortlog -sn) among contributors to fail2ban (by 'number' of commits at least) -- so -- thanks and keep PRs coming (there is so much which could be improved and not just in the code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants