-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(finance): use validator.js for bitcoin addresses #1375
Merged
Shinigami92
merged 12 commits into
faker-js:main
from
Minozzzi:fix/finance/validate-bitcoin-address
Sep 21, 2022
Merged
test(finance): use validator.js for bitcoin addresses #1375
Shinigami92
merged 12 commits into
faker-js:main
from
Minozzzi:fix/finance/validate-bitcoin-address
Sep 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1375 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2163 2163
Lines 241264 241264
Branches 1014 1014
=======================================
Hits 240357 240357
Misses 886 886
Partials 21 21
|
import-brain
added
c: test
m: finance
Something is referring to the finance module
labels
Sep 13, 2022
Shinigami92
requested changes
Sep 13, 2022
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ST-DDT
approved these changes
Sep 21, 2022
import-brain
approved these changes
Sep 21, 2022
Shinigami92
changed the title
test(finance/bitcoinAddress): use validator.js to test generated data
test(finance): use validator.js to test generated bitcoin addresses
Sep 21, 2022
Shinigami92
approved these changes
Sep 21, 2022
Shinigami92
changed the title
test(finance): use validator.js to test generated bitcoin addresses
test(finance): use validator.js for bitcoin addresses
Sep 21, 2022
wael-fadlallah
pushed a commit
to wael-fadlallah/faker
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1184