-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: glibc 2.38 builder #316
Conversation
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Moreover, switch to setup-go@v4 that supports caching by default. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
I was able to successfully build a kernel module for 6.6.5 arch kernel (that #303 complained we weren't able to build):
I built the new builder image for x86_64 and pushed it to my own dockerhub repository; then:
|
@@ -135,6 +135,11 @@ type GCCVersionRequestor interface { | |||
|
|||
func defaultGCC(kr kernelrelease.KernelRelease) semver.Version { | |||
switch kr.Major { | |||
case 6: | |||
if kr.Minor >= 6 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6.6+ will use gcc 13.
@@ -150,7 +155,7 @@ func defaultGCC(kr kernelrelease.KernelRelease) semver.Version { | |||
case 2: | |||
return semver.Version{Major: 4, Minor: 8} | |||
default: | |||
return semver.Version{Major: 12} | |||
return semver.Version{Major: 13} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux 7.x will default at using gcc 13 :D
/cc @EXONER4TED @dwindsor |
/hold for eventual discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something we actually have been needing downstream as well. All for this 🙂
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EXONER4TED, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
/area pkg
What this PR does / why we need it:
This PR introduces a new fedora based
any
builder to be able to build recent kernels (6.6+) that require glibc 2.38.Which issue(s) this PR fixes:
Fixes #303
Special notes for your reviewer:
Does this PR introduce a user-facing change?: