-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GKE default pod into allowlist in Mount Launched of Privileged Container rule #2198
Add GKE default pod into allowlist in Mount Launched of Privileged Container rule #2198
Conversation
Signed-off-by: Hi120ki <12624257+hi120ki@users.noreply.github.com>
Hi @hi120ki , |
Signed-off-by: Hi120ki <12624257+hi120ki@users.noreply.github.com>
@darryk10 I see. I revert and add new macro |
/milestone 0.33.0 /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hi120ki
LGTM
LGTM label has been added. Git tree hash: 1c9189cac088f67f7e9d69e3b83a1e3cac740fd4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darryk10, hi120ki, jasondellaluce, Kaizhe, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closing and reopening to trigger the CI |
@leogr: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen /hold |
@leogr: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
Signed-off-by: Hi120ki 12624257+hi120ki@users.noreply.github.com
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
In GKE cluster, a system container
gce-pd-driver
that manages Persistent Disk is running.But the rule
Mount Launched of Privileged Container
detects as false positive.This container runs in
kube-system
namespace, and image is fromgke.gcr.io/gcp-compute-persistent-disk-csi-driver
.I added it into allowlist(macro :
user_known_mount_in_privileged_containers
).I'm waiting for your comments on adding it into allowlist and my proposed changes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: