Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error in signal emission #1554

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

StefansM
Copy link
Contributor

The CanvasBox.positionChanged signal expects to receive x and y as
ints, but they were being passed as floats, which were mangled at the
receiving signal handler.

This manifested as huge x and y values for canvas boxes, and when
saving and loading projects all boxes would hit the edge of the canvas
and get placed at the extreme edge.

The `CanvasBox.positionChanged` signal expects to receive `x` and `y` as
`int`s, but they were being passed as `float`s, which mangled them on
the receiving signal handler.

This manifested as huge `x` and `y` values for canvas boxes, and when
saving and loading projects all boxes would hit the edge of the canvas
and get placed at the extreme edge.
@StefansM
Copy link
Contributor Author

I don't know much about QT, so my terminology might be wrong - feel free to adjust the PR message before merging!

@StefansM
Copy link
Contributor Author

I believe this addresses #1552.

@All3xJ
Copy link

All3xJ commented Dec 30, 2021

This probably fixes this issue: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1945
that I thought was a pipewire problem, but it's the Catia's bug.

@All3xJ
Copy link

All3xJ commented Dec 30, 2021

when will this new version go out?

@mxmilkiib
Copy link
Contributor

mxmilkiib commented Dec 30, 2021

Out for yourself or someone else? What distro are you on? You could clone the forked repo, checkout the branch and make n make install, or if Arch based, copy n edit the AUR PKGBUILD to point to the other repo+branch and build that way, though maybe the PR will be approved soon and using a Carla -git package would suit. Though you do mention Catia not Carla..

@All3xJ
Copy link

All3xJ commented Dec 30, 2021

@mxmilkiib thanks for answer. I forked Catia's repo and edited the PKGBUILD of catia-git pkg from AUR(since I have ArchLinux) and installed Catia. But the bug is still there, so I don't think that this fixes the bug also in Carla... @StefansM

@falkTX
Copy link
Owner

falkTX commented Dec 30, 2021

@All3xJ you are confusing carla and catia ;)

@All3xJ
Copy link

All3xJ commented Jan 2, 2022

@All3xJ you are confusing carla and catia ;)

No ahaha I know they are different. Just I have found it weird that two very similar softwares have the same bug at the same time (#1552 was reported 14 days ago, which was more or less the same period I encoutered the bug in Catia). So I think they are in some way related. Again, this commit does not help for me in Catia. I also tried downgrading pipewire, but it does not fix. I don't really know what could have caused the issue.

@All3xJ
Copy link

All3xJ commented Jan 2, 2022

Ok, I confirm that this unfortunately does not fix the bug in Carla neither (I builded the patched @StefansM version). Apparently, to fix #1552 , is enough to downgrade:
python 3.10.1-2 ->3.9.9-1
python-pyqt5 5.15.6-6 -> 5.15.6-2
python-pyqt5-sip 12.9.0-3 ->12.9.0-1

@udf
Copy link

udf commented Jan 2, 2022

@All3xJ Note that downgrading python breaks all other python- packages installed from the repos, it's not even a good temporary solution. We still need to figure out why upgrading to 3.10 breaks it.

@falkTX falkTX merged commit c9c0375 into falkTX:main Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants