-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type error in signal emission #1554
Conversation
The `CanvasBox.positionChanged` signal expects to receive `x` and `y` as `int`s, but they were being passed as `float`s, which mangled them on the receiving signal handler. This manifested as huge `x` and `y` values for canvas boxes, and when saving and loading projects all boxes would hit the edge of the canvas and get placed at the extreme edge.
I don't know much about QT, so my terminology might be wrong - feel free to adjust the PR message before merging! |
I believe this addresses #1552. |
This probably fixes this issue: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1945 |
when will this new version go out? |
Out for yourself or someone else? What distro are you on? You could clone the forked repo, checkout the branch and make n make install, or if Arch based, copy n edit the AUR PKGBUILD to point to the other repo+branch and build that way, though maybe the PR will be approved soon and using a Carla -git package would suit. Though you do mention Catia not Carla.. |
@mxmilkiib thanks for answer. I forked Catia's repo and edited the PKGBUILD of catia-git pkg from AUR(since I have ArchLinux) and installed Catia. But the bug is still there, so I don't think that this fixes the bug also in Carla... @StefansM |
@All3xJ you are confusing carla and catia ;) |
No ahaha I know they are different. Just I have found it weird that two very similar softwares have the same bug at the same time (#1552 was reported 14 days ago, which was more or less the same period I encoutered the bug in Catia). So I think they are in some way related. Again, this commit does not help for me in Catia. I also tried downgrading pipewire, but it does not fix. I don't really know what could have caused the issue. |
@All3xJ Note that downgrading python breaks all other python- packages installed from the repos, it's not even a good temporary solution. We still need to figure out why upgrading to 3.10 breaks it. |
The
CanvasBox.positionChanged
signal expects to receivex
andy
asint
s, but they were being passed asfloat
s, which were mangled at thereceiving signal handler.
This manifested as huge
x
andy
values for canvas boxes, and whensaving and loading projects all boxes would hit the edge of the canvas
and get placed at the extreme edge.