Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specter doesn't respawn + error when using /s attack #85

Closed
ghost opened this issue Dec 27, 2019 · 9 comments · Fixed by #86
Closed

specter doesn't respawn + error when using /s attack #85

ghost opened this issue Dec 27, 2019 · 9 comments · Fixed by #86

Comments

@ghost
Copy link

ghost commented Dec 27, 2019

[Server thread/CRITICAL]: Error: "Undefined class constant 'ACTION_RIGHT_CLICK'" (EXCEPTION) in "plugins/Specter-master/src/specter/Specter" at line 123

pocketmine: 3.11.1

@inxomnyaa
Copy link
Collaborator

I can confirm this, this happened to me recently. I am yet unsure why specter used the right click action, and what it does. I will check if it is for arm swinging and fix it asap

@inxomnyaa
Copy link
Collaborator

Fixed arm swing and attacking in b39d20d

I will check respawn asap

@inxomnyaa
Copy link
Collaborator

Respawn fixed in 10c118e

@ghost
Copy link
Author

ghost commented Dec 28, 2019

also some plugins can't fetch the specter device model and then the server crashes

@inxomnyaa
Copy link
Collaborator

can't fetch the specter device mode

Then those plugins should fix it - there is no official implementation of device model/device OS in pmmp. I can not set a specific OS by default, this would be inaccurate

@inxomnyaa
Copy link
Collaborator

^ hmm, maybe i can set the OS as -1 (undefined)

@falkirks as SOFe told me, i need admin repo access to schedule updates to poggit, can you do that?

@falkirks
Copy link
Owner

falkirks commented Apr 3, 2020

Yup I can do that, just tag a release on GitHub and I can put it on poggit. Is there a way to give you admin access though? Or just email me if I don’t reply fast enough at me@falkirks.com

@inxomnyaa
Copy link
Collaborator

I have no idea how to do it, i know there is "transfer ownership", but i dont think thats what we want

@SOF3
Copy link
Contributor

SOF3 commented Apr 4, 2020

Perhaps I should change Poggit config to allow anyone with write access to submit the plugin

inxomnyaa added a commit that referenced this issue Apr 4, 2020
… crashes

See a comment in #85
Before release the "DeviceOS" field must be validated. Can not trust sources like Steadfast.
Putting -1 as they defined in their Player class would crash the plugin PlayerInfo. (that thing should validate client input anyways duh..)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants