Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sort sophus more consistent into directory structure #113

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

strasdat
Copy link
Member

@strasdat strasdat commented Aug 19, 2023

  • sort cpp/sophus2 better into existing directory structure
    • moves cpp/sophus2/cpp/sophus -> cpp/sophus
    • moves cpp/sophus2/protos to protos/sophus
    • moves cpp/sophus2/docs -> docs
    • remove lots of unused scripts
  • dependency management
    • document venv
    • merge / simply venv build scripts
  • fix all build scripts CI to reflect the change

Note: This PR won't attempt to merge geometric protos from sophus with duplicates protos in the farm_ng namespace. This will be done in follow-up, while aiming to minimize log format disruptions.

@strasdat strasdat force-pushed the refactor-sophus2 branch 5 times, most recently from 1cb7cd2 to 583612f Compare August 19, 2023 18:12
@strasdat strasdat marked this pull request as draft August 19, 2023 21:05
@strasdat strasdat force-pushed the refactor-sophus2 branch 2 times, most recently from 7988e7f to 4b18128 Compare August 21, 2023 17:49
@strasdat strasdat marked this pull request as ready for review August 21, 2023 17:51
@strasdat strasdat force-pushed the refactor-sophus2 branch 9 times, most recently from dee3f6f to c8fc212 Compare August 22, 2023 02:11
Copy link
Member

@ethanrublee ethanrublee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @strasdat Feel free to merge any time you are ready. Any missing clean up can be done as smaller PRs and looks like you've hit all your goals for this PR.

@strasdat strasdat merged commit c5d0be3 into main Aug 22, 2023
4 checks passed
@strasdat strasdat deleted the refactor-sophus2 branch August 22, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants