Fix asset_lookup and term_lookup exception messages #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstenta
force-pushed
the
2.x-fix-lookup-errors
branch
from
7e31e16
to
93b9283
Compare
paul121
approved these changes
Oct 9, 2023
mstenta
force-pushed
the
2.x-fix-lookup-errors
branch
from
93b9283
to
1e23d0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an oversight during #722 development. Initially I was translating these messages with a placeholder, but PHP Codesniffer / PHPStan (can't remember which) told me not to translate them, so I removed the
$this->t()but forgot to refactor the placeholder bit.