Inventory quick form #766
Inventory quick form #766
Conversation
mstenta
force-pushed
the
3.x-quick-inventory
branch
from
74999ae
to
4abd727
Compare
There was a problem hiding this comment.
I'm getting an error when I try to configure the units on the quick form with a new term that does not exist. It gets a 500 error with this log message:
InvalidArgumentException: The configuration property settings.units.entity doesn't exist. in Drupal\Core\Config\Schema\ArrayElement->get() (line 76 of /var/www/html/web/core/lib/Drupal/Core/Config/Schema/ArrayElement.php).
mstenta
force-pushed
the
3.x-quick-inventory
branch
from
4abd727
to
ccb0d2e
Compare
Oh good catch @paul121! This made me think of something related: maybe we should store the term label instead of the term ID in the configuration entity for inventory quick forms. This would allow the config YML to be shared between farmOS instances without any hard-coded term IDs. The term can be generated on-demand using our I've pushed a commit to that effect. Requesting your review... I also rebased onto latest |
mstenta
force-pushed
the
3.x-quick-inventory
branch
from
ccb0d2e
to
f5d053f
Compare
mstenta
force-pushed
the
3.x-quick-inventory
branch
from
c220df9
to
27ea902
Compare
| @@ -494,7 +496,10 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta | |||
| */ | |||
| public function submitConfigurationForm(array &$form, FormStateInterface $form_state) { | |||
| $this->configuration['asset'] = $form_state->getValue('asset'); | |||
| $this->configuration['units'] = $form_state->getValue('units'); | |||
| $this->configuration['units'] = ''; | |||
There was a problem hiding this comment.
I believe this would end up saving an empty string if nothing was provided?
There was a problem hiding this comment.
True, I suppose it should explicitly set it to NULL if that's the new default. I'll change it to NULL.
We do need to explicitly set it here otherwise there's no way to "unset" units in configuration.
mstenta
force-pushed
the
3.x-quick-inventory
branch
from
27ea902
to
a738dfd
Compare
The entity_autocomplete widget's values are different depending on whether the selected term already exists. If it exists, the value is the term ID. If it is being created, the value is an array with an 'entity' key containing the new TermInterface object.
mstenta
force-pushed
the
3.x-quick-inventory
branch
from
a738dfd
to
a09ef42
Compare
This adds an Inventory quick form. For more details on the design and discussion, refer to the following links: