Field Modules (experimental) #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 28, 2019
Closed
jgaehring
force-pushed
the
field-module
branch
2 times, most recently
from
e22e88d
to
f4ae55b
Compare
jgaehring
force-pushed
the
field-module
branch
from
4af4d40
to
9c2c930
Compare
jgaehring
force-pushed
the
field-module
branch
from
9c2c930
to
ede6f1b
Compare
jgaehring
force-pushed
the
field-module
branch
3 times, most recently
from
8a37993
to
f99332e
Compare
jgaehring
force-pushed
the
field-module
branch
5 times, most recently
from
51e7c84
to
f390bf6
Compare
jgaehring
force-pushed
the
field-module
branch
3 times, most recently
from
12b0055
to
4717657
Compare
jgaehring
force-pushed
the
field-module
branch
from
abacba8
to
e6bf9f0
Compare
jgaehring
force-pushed
the
field-module
branch
from
353244e
to
00698de
Compare
jgaehring
force-pushed
the
field-module
branch
from
00698de
to
cfd5295
Compare
jgaehring
force-pushed
the
field-module
branch
from
cfd5295
to
2f1015c
Compare
jgaehring
force-pushed
the
field-module
branch
3 times, most recently
from
ed1823e
to
a4f7101
Compare
jgaehring
force-pushed
the
field-module
branch
2 times, most recently
from
bcea25a
to
aa5fcb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very experimental (though functional) implementation of our proposed "Field Modules" idea, which goes all the way back to issue #38. I'll probably open a new issue to discuss the future potential of this feature in more detail. This PR is not really intended to be merged, but is for documentation purposes.
Some notes on the implementation:
In order to serve the plugin's script, which doesn't get picked up by Webpack, I had to spin up a separate http server. I used the Chrome Web Server, with the root directory set to
/src/vue-plugins/test-pluginand with CORS headers enabled in the Advanced Settings. That serves theindex.jsfile fromhttp://127.0.0.1:8887/index.js, which I've hardcoded into themanifest.json. Someone serving the files from a different port may need to edit that.In the future it might be desirable to move field module loader deeper into the app, perhaps to one of
App.vue's life-cycle hooks, or perhaps its own Vuex module. The reason for this would be to access the user info and auth status, stored in Vuex, although this could also just be accessed directly via localStorage.