Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cursor direction. #329

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Change cursor direction. #329

merged 2 commits into from
Mar 24, 2020

Conversation

jgaehring
Copy link
Member

A test to see if this fixes #324.

🤞

@jgaehring
Copy link
Member Author

This appears to be a bug in Safari, so I opened a report here: https://bugs.webkit.org/show_bug.cgi?id=209429.

Since this can't really be resolved on our own, I've implemented a workaround, which hopefully won't have any adverse affects. Basically, instead of advancing the cursor the previous unique item, it should just advance to whatever the previous item is. There shouldn't be non-unique items in the stores, so long as we're generating the localID's correctly, but it was a nice safety measure to be able to select on unique items. Perhaps if the bug in Safari gets fixed we can revert. In any event, this should indeed resolve #324.

I've also included a fix for another bug I found, which was overwriting defaults in fresh installs and causing errors.

@jgaehring jgaehring merged commit 41a5e91 into master Mar 24, 2020
@jgaehring jgaehring deleted the fix324 branch March 24, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Login & Sync errors in iOS
1 participant