Docker Extension 0.1.4 for Airbyte v40 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-gerber
requested review from
cjwooo,
tovbinm,
ypc-faros and
ogusak
as code owners
cjwooo
approved these changes
May 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must re-release our docker extension so that the Airbyte version matches the latest init. It will be 0.1.4, which I will run from my machine.
I have decided to keep the faros-init-ce image tag to
latestinstead of fixing the version so the extension still benefits from improvements without having to re-release. This is the right tradeoff given that the compose only rarely goes out of sync with the init container (like here).Once this is approved, I will runI have already run
make push-extension TAG=0.1.4since 0.1.3 is currently broken since we released the latest init.(it isn't broken because the API used in new init are backward compatible)I will check that the update process is smooth for extension users.It worked!