Removes anonymous telemetry #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep Segment MTUs under control, as hostnames will change on docker
thomas-gerber
requested review from
cjwooo,
tovbinm,
ypc-faros and
ogusak
as code owners
|
Tested with both with and without email provided during setup. |
thomas-gerber
force-pushed
the
no_anon_telemetry
branch
from
afea21e
to
282a578
Compare
tovbinm
reviewed
Sep 15, 2023
| host?: string | undefined | ||
| ): Promise<void> { | ||
| const analytics = new Analytics('YEu7VC65n9dIR85pQ1tgV2RHQHjo2bwn', { | ||
| if (segmentUser === undefined) { | ||
| logger.info('Skipping Telemetry'); |
There was a problem hiding this comment.
Probably not need to log anything at all.
tovbinm
approved these changes
Sep 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep Segment MTUs under control.