Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds tracking and logging best metrics to wandb cb #3372

Closed
wants to merge 2 commits into from
Closed

adds tracking and logging best metrics to wandb cb #3372

wants to merge 2 commits into from

Conversation

arampacha
Copy link
Contributor

As per my understanding currently one can use only the last logged metric in W&B in some scenarios (e.g. comparing runs in sweep, reporting scores with barplot etc.) which might be inconvenient when best score is different from final score. This PR adds logging best_metrics dict, which contain the best observed scores during the run. best_metrics contains an entry for each logged metric named best_{metric_name}. The compare argument is added to __init__ to allow user to provide custom list of comparison functions as it's not trivial to automate determining appropriate functions for all possible scenarios, I aimed made it consistent with TrackerCallback in this regard.

cc @morganmcg1 @borisdayma

@arampacha arampacha requested a review from jph00 as a code owner May 12, 2021 18:18
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@borisdayma
Copy link
Contributor

Awesome!
I try to always reuse existing parameters from other callbacks. Don't we already have access to best metrics? Maybe here

@arampacha
Copy link
Contributor Author

@borisdayma If I understand it correctly recorder.log contains the metrics corresponding to the most recent epoch not the best one. And there is separate TrackerCallback here which monitors best value for early stopping and saving model. But it only monitors particular metric selected for monitoring, while all metrics might be interesting for analysis using W&B.

@borisdayma
Copy link
Contributor

Is there a way to add TrackerCallback and make it monitor every metric?
Just trying to find a way to make it easily maintainable.

@jph00
Copy link
Member

jph00 commented Jun 15, 2021

@arampacha @borisdayma I'll leave this open until you two have resolved the above conversation

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants